linux-kernel - Re: [PATCH v14 16/18] vmpressure: in-kernel notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA6-i6rqCm44yJjf0dy=L+rYGEH=WUoNzX4+qh5poGgSsA=W-Q@mail.gmail.com>
Date:	Fri, 20 Dec 2013 18:32:41 +0400
From:	Glauber Costa <glommer@...il.com>
To:	Luiz Capitulino <lcapitulino@...hat.com>
Cc:	Vladimir Davydov <vdavydov@...allels.com>, dchinner@...hat.com,
	Michal Hocko <mhocko@...e.cz>,
	Johannes Weiner <hannes@...xchg.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
	cgroups@...r.kernel.org, devel@...nvz.org,
	Glauber Costa <glommer@...nvz.org>,
	John Stultz <john.stultz@...aro.org>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Kamezawa Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [PATCH v14 16/18] vmpressure: in-kernel notifications

One correction:

>>  int vmpressure_register_kernel_event(struct cgroup_subsys_state *css,
>> -                                     void (*fn)(void))
>> +                                    void (*fn)(void *data, int level), void *data)
>>  {
>> -       struct vmpressure *vmpr = css_to_vmpressure(css);
>> +       struct vmpressure *vmpr;
>>         struct vmpressure_event *ev;
>>
>> +       vmpr = css ? css_to_vmpressure(css) : memcg_to_vmpressure(NULL);
>> +

This looks like it could be improved. Better not to have that memcg
specific thing
here.

Other than that it makes sense.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/