linux-kernel - Re: [PATCHv2 1/3] silicom: fix whitespace issues in bypass.c

Open Source and information security mailing list archives

Message-ID: <CADKvho6HF9A6agDXwrg7UPcOS0YQh3bPmGzPjOAEO8tZ8cveTw@mail.gmail.com>
Date:	Fri, 20 Dec 2013 20:36:48 +0530
From:	Gokulnath A <gokul.linux@...il.com>
To:	Michael Hoefler <michael.hoefler@...dium.uni-erlangen.de>
Cc:	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	linux-kernel@...cs.fau.de,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Christoph Kohl <christoph.kohl@...nline.de>,
	open list <linux-kernel@...r.kernel.org>,
	Rupert Muchembled <rupert@...ch.net>
Subject: Re: [PATCHv2 1/3] silicom: fix whitespace issues in bypass.c

Hello Michael,

On Fri, Dec 20, 2013 at 7:21 PM, Michael Hoefler
<michael.hoefler@...dium.uni-erlangen.de> wrote:
> This patch addresses several problems in bypass.c found by checkpatch.
> Furthermore it removes/adds some empty lines to make the code more readable.
>
> The following problems are fixed:
>  - line over 80 characters
>  - space after logical operator !
>  - spaces instead of tabs
>  - missing empty line after local declarations
>  - empty line after {
>

Please do one thing per patch, As Greg suggested for me in previous mail
conversations. Here you could have at least 3 or 4 patches.
For example, first patch would be a fix for line over 80 characters,
followed by the other problems as mentioned above by you.

> The empty line issues were not discovered by checkpatch but in my opinion these
> changes make perfect sense in terms of readability.
>
> Signed-off-by: Michael Hoefler <michael.hoefler@...dium.uni-erlangen.de>
> Signed-off-by: Christoph Kohl <christoph.kohl@...nline.de>
> ---
>  drivers/staging/silicom/bypasslib/bypass.c | 111 ++++++++++++++++-------------
>  1 file changed, 61 insertions(+), 50 deletions(-)
>
 1.8.1.2
>
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives