linux-kernel - Re: [PATCH 2/2] GenWQE: Replace dynamic_hex_dump with print_hex_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131220153309.GA21797@kroah.com>
Date:	Fri, 20 Dec 2013 07:33:09 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Frank Haverkamp <haver@...ux.vnet.ibm.com>
Cc:	fengguang.wu@...el.com, jim.epost@...il.com, sfr@...b.auug.org.au,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	kbuild-all@...org
Subject: Re: [PATCH 2/2] GenWQE: Replace dynamic_hex_dump with
 print_hex_dump_debug

On Fri, Dec 20, 2013 at 04:26:11PM +0100, Frank Haverkamp wrote:
> As requested by Greg, replacing the hexdump function from dynamic_debug.h
> with one defined in printk.h. I hope I picked the right one.

No, just use the "%*ph" modifier for printk.

So, you can do it all on just one line:
  	scnprintf(prefix, sizeof(prefix), "%s %s: %*ph\n",
  		  GENWQE_DEVNAME, pci_name(pci_dev), size, buff);

And even then, do you really need this genwqe_hexdump() function at all
anymore?  What is it used for?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/