linux-kernel - Re: [PATCH 1/2] GenWQE: Fix endian issues detected by sparse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1387566773.1847.28.camel@oc7383187364.ibm.com>
Date:	Fri, 20 Dec 2013 20:12:53 +0100
From:	Frank Haverkamp <haver@...ux.vnet.ibm.com>
To:	fengguang.wu@...el.com
Cc:	jim.epost@...il.com, sfr@...b.auug.org.au,
	gregkh@...uxfoundation.org, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, kbuild-all@...org
Subject: Re: [PATCH 1/2] GenWQE: Fix endian issues detected by sparse

Hi Greg,

Am Freitag, den 20.12.2013, 16:26 +0100 schrieb Frank Haverkamp:
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -59,7 +59,7 @@ int __genwqe_writeq(struct genwqe_dev *c
>         if (cd->mmio == NULL)
>                 return -EIO;
> 
> -       __raw_writeq(cpu_to_be64((val)), (cd->mmio + byte_offs));
> +       __raw_writeq((__force u32)cpu_to_be64(val), cd->mmio +
> byte_offs);

what a pity. I introduced here a wrong cast to u32 and not to u64 what
it should have been. I will send a fix, once I have tried it out.

Regards

Frank

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/