linux-kernel - Re: [PATCH] drivers: dgnc: Include appropriate header file in dgnc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131221105423.GE3611@leaf>
Date:	Sat, 21 Dec 2013 02:54:23 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Lidza Louina <lidza.louina@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] drivers: dgnc: Include appropriate header file in
 dgnc_trace.c

On Sat, Dec 21, 2013 at 03:52:38PM +0530, Rashika Kheria wrote:
> Include appropriate header file dgnc/dgnc_trace.h in dgnc_trace.c
> because function dgnc_tracer_free() has its prototype declaration in the
> header file.
> 
> This eliminates the following warning in dgnc_trace.c:
> drivers/staging/dgnc/dgnc_trace.c:180:6: warning: no previous prototype for ‘dgnc_tracer_free’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  drivers/staging/dgnc/dgnc_trace.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/dgnc/dgnc_trace.c b/drivers/staging/dgnc/dgnc_trace.c
> index a98b7d4..e2164e4 100644
> --- a/drivers/staging/dgnc/dgnc_trace.c
> +++ b/drivers/staging/dgnc/dgnc_trace.c
> @@ -35,6 +35,7 @@
>  #include <linux/vmalloc.h>
>  
>  #include "dgnc_driver.h"
> +#include "dgnc_trace.h"
>  
>  #define TRC_TO_CONSOLE 1
>  
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/