linux-kernel - Re: [PATCH] powercap/rapl: add support for ValleyView Soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1312221420400.13165@pianoman.cluster.toy>
Date:	Sun, 22 Dec 2013 14:22:48 -0500 (EST)
From:	Vince Weaver <vince@...ter.net>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
cc:	Jacob Pan <jacob.jun.pan@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux PM <linux-pm@...r.kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Rafael Wysocki <rafael.j.wysocki@...el.com>,
	Gavin Hindman <gavin.hindman@...el.com>,
	"Triplett, Josh" <josh.triplett@...el.com>
Subject: Re: [PATCH] powercap/rapl: add support for ValleyView Soc

On Sun, 22 Dec 2013, Rafael J. Wysocki wrote:
> On Wednesday, December 11, 2013 02:39:27 PM Jacob Pan wrote:

> > @@ -941,6 +949,7 @@ static void package_power_limit_irq_restore(int package_id)
> >  static const struct x86_cpu_id rapl_ids[] = {
> >  	{ X86_VENDOR_INTEL, 6, 0x2a},/* SNB */
> >  	{ X86_VENDOR_INTEL, 6, 0x2d},/* SNB EP */
> > +	{ X86_VENDOR_INTEL, 6, 0x37},/* VLV */
> >  	{ X86_VENDOR_INTEL, 6, 0x3a},/* IVB */
> >  	{ X86_VENDOR_INTEL, 6, 0x45},/* HSW */
> >  	/* TODO: Add more CPU IDs after testing */

This isn't a problem introduced in this patch, but it made me notice it...

Would it really hurt anyone to spell out the architectures here, rather
than using obscure 3-letter abbreviations?  It's bad enough trying to
map the hex model numbers to the decimal ones in /proc/cpuinfo without
also having to remember what a VLV is.

Vince
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/