linux-kernel - Re: [PATCH v4 1/3] regulator: act8865: add PMIC act8865 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131223115746.GR30815@sirena.org.uk>
Date:	Mon, 23 Dec 2013 11:57:46 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Wenyou Yang <wenyou.yang@...el.com>
Cc:	lgirdwood@...il.com, linux-kernel@...r.kernel.org,
	grant.likely@...aro.org, rob.herring@...xeda.com,
	linux-doc@...r.kernel.org, vpalatin@...omium.org,
	nicolas.ferre@...el.com, plagnioj@...osoft.com,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v4 1/3] regulator: act8865: add PMIC act8865 driver

On Mon, Dec 23, 2013 at 01:25:28PM +0800, Wenyou Yang wrote:

> +static int act8865_set_suspend_voltage(struct regulator_dev *rdev, int uV)
> +{
> +	u32	selector;
> +
> +	selector = regulator_map_voltage_iterate(rdev, uV, uV);
> +
> +	return regulator_set_voltage_sel_regmap(rdev, selector);
> +}

This looks wrong - it's going to set the normal voltage register that is
set for runtime voltage changes.  The suspend operations are only for
setting separate voltage registers, many PMICs know about system suspend
and provide separate settings for that.  If this one doesn't then it
shouldn't implement this operation.

Otherwise this looked good.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/