linux-kernel - Re: [PATCH v3 1/2] regulator: anatop-regulator: Fix the error handling on probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131223145020.GN26070@S2101-09.ap.freescale.net>
Date:	Mon, 23 Dec 2013 22:50:22 +0800
From:	Shawn Guo <shawn.guo@...aro.org>
To:	Fabio Estevam <festevam@...il.com>
CC:	<broonie@...nel.org>, <Anson.Huang@...escale.com>,
	<linux-kernel@...r.kernel.org>,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH v3 1/2] regulator: anatop-regulator: Fix the error
 handling on probe

On Mon, Dec 23, 2013 at 12:44:40PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@...escale.com>
> 
> Currently when of_get_parent() or syscon_node_to_regmap() fail 
> 'kfree(sreg->name)' is not called, which is incorrect.
> 
> Fix this by jumping to 'anatop_probe_end' instead.
> 
> While at it, make 'anatop_probe_end' to be executed only on the error path, so
> that the code can be a bit easier to follow.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

Acked-by: Shawn Guo <shawn.guo@...aro.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/