linux-kernel - Re : Re: Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF207E4497.72720BDC-ON49257C4A.0010D055-49257C4A.0010D055@lge.com>
Date:	Mon, 23 Dec 2013 12:03:39 +0900
From:	"Chanho Min" <chanho.min@....com>
To:	Minchan Kim <minchan@...nel.org>
Cc:	Phillip Lougher <phillip@...ashfs.org.uk>,
	linux-kernel@...r.kernel.org,
	임효준 <hyojun.im@....com>,
	이건호 <gunho.lee@....com>
Subject: Re : Re: Re: Re : Re: [PATCH] Squashfs: add asynchronous read support



> read_pages
>   for(page_idx ...) {
>     if (!add_to_page_cache_lru)) { <-- 1)
>       mapping->a_ops->readpage(filp, page)
>         squashfs_readpage
>           for (i ...) {   2)  Here, 31 pages are inserted into page cache
>             grab_cahe_page_nowait <------/
>               add_to_page_cache_lru
>           }
>     }
>     /*
>      * 1) will be failed with EEXIST by 2) so every pages other than first page
>      * in list would be freed
>      */
>     page_cache_release(page)
>   }
>
> If you see ReadAhead works, it is just by luck as I told you.
> Please simulate it with 64K dd.
You right, This luck happened frequently with 128k dd or my test.

> I understand it but your patch doesn't make it.
>
I think my patch can make it if readahead works normally or luckily.

Thanks a lot!
Chanho,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/