linux-kernel - Re: [PATCH 3/4] block: null_blk: fix queue leak inside removing device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131223162650.GC9383@infradead.org>
Date:	Mon, 23 Dec 2013 08:26:50 -0800
From:	Christoph Hellwig <hch@...radead.org>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] block: null_blk: fix queue leak inside removing
 device

On Tue, Dec 24, 2013 at 12:18:58AM +0800, Ming Lei wrote:
>  	del_gendisk(nullb->disk);
> -	if (queue_mode == NULL_Q_MQ)
> -		blk_mq_free_queue(nullb->q);
> -	else
> -		blk_cleanup_queue(nullb->q);
> +	blk_cleanup_queue(nullb->q);

All exported users of blk_mq_free_queue go away with this change, so
make sure it's not available anymore.  I have to say the one in
blk-sysfs.c also looks suspicious.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/