linux-kernel - Re: [PATCH] irq-renesas-irqc: simplify irq_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131223002729.GB25868@verge.net.au>
Date:	Mon, 23 Dec 2013 09:27:32 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Magnus Damm <magnus.damm@...il.com>
Cc:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	SH-Linux <linux-sh@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] irq-renesas-irqc: simplify irq_set_type() method

On Thu, Dec 19, 2013 at 06:53:32PM +0900, Magnus Damm wrote:
> On Thu, Dec 19, 2013 at 5:24 PM, Simon Horman <horms@...ge.net.au> wrote:
> > On Sat, Dec 14, 2013 at 03:09:31AM +0300, Sergei Shtylyov wrote:
> >> Value 0 of the sense  selection field of CONFIG_n register means "disable event
> >> detection" and serves in irqc_sense[] for marking the invalid values of the IRQ
> >> type (by just omitting initializers). There is no need for INTC_IRQ_SENSE_VALID
> >> and hence INTC_IRQ_SENSE() as all field values matching to the  valid IRQ types
> >> are non-zero anyway.
> >>
> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> >
> > Magnus, could you review this?
> 
> The patch is IMO only cosmetic so I can't say I care that much. But
> since you ask. =)
> 
> Acked-by: Magnus Damm <damm@...nsource.se>

Thanks, I have queued this up.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/