linux-kernel - Re: [PATCHSET 0/7] perf tools: A couple of TUI improvements (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8761qgdtt2.fsf@sejong.aot.lge.com>
Date:	Mon, 23 Dec 2013 14:23:37 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCHSET 0/7] perf tools: A couple of TUI improvements (v2)

Hi Jiri,

On Fri, 20 Dec 2013 18:33:51 +0100, Jiri Olsa wrote:
> On Fri, Dec 20, 2013 at 02:11:11PM +0900, Namhyung Kim wrote:
>> Hello,
>> 
>> I was playing with TUI code and added two new windows.  One for
>> showing log messages and another for showing header information.
>> (Maybe they can be implemented on the GTK code too someday.)
>> 
>>  * changes from v1)
>>   - fix segfault on perf top (Ingo)
>>   - split print function handling patch (Arnaldo)
>>   - add filtering support on log window (Jiri, Ingo)
>> 
>> 
>> I put the patches on 'perf/tui-v2' branch in my tree:
>> 
>>   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
>> 
>> Any feedbacks are more than welcome, thanks
>> Namhyung
>
> got segfault in perf top:
> (pressed 'l' and several searches)

Hmm.. so did you this crash in the log window?  How many logs in the
window - more than 100 or so?  Could you reproduce it regularly?

>
> 0x14cde0 __memmove_ssse3_back: period++ [addr: 0x14db58, 0xd78, evidx=0] => 10
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x7fffeaf4a700 (LWP 8368)]
> ____rb_erase_color (augment_rotate=<optimized out>, root=<optimized out>, parent=0x157bd70)
>     at ../../lib/rbtree.c:229
> 229                                     rb_set_parent_color(tmp1, parent, RB_BLACK);
> Missing separate debuginfos, use: debuginfo-install
> audit-libs-2.3.2-1.fc19.x86_64 elfutils-libelf-0.156-5.fc19.x86_64
> elfutils-libs-0.156-5.fc19.x86_64 libunwind-1.1-2.fc19.x86_64
> nss-softokn-freebl-3.15.3-1.fc19.x86_64
> numactl-libs-2.0.8-4.fc19.x86_64 perl-libs-5.16.3-266.fc19.x86_64
> python-libs-2.7.5-9.fc19.x86_64 slang-2.2.4-8.fc19.x86_64
> xz-libs-5.1.2-4alpha.fc19.x86_64 zlib-1.2.7-10.fc19.x86_64
> (gdb) bt
> #0  ____rb_erase_color (augment_rotate=<optimized out>, root=<optimized out>, parent=0x157bd70)
>     at ../../lib/rbtree.c:229
> #1  rb_erase (node=node@...ry=0x29bb500, root=root@...ry=0x946a00) at ../../lib/rbtree.c:397
> #2  0x000000000049e0f4 in hists__collapse_resort (hists=0x9469f8, prog=prog@...ry=0x0) at util/hist.c:567
> #3  0x0000000000432135 in perf_top__sort_new_samples (arg=0x7fffffffb270) at builtin-top.c:553
> #4  0x00000000004cb64d in hist_browser__run (hbt=0x7fffeaf49ea0, ev_name=0x946c60 "cycles", 
>     browser=<optimized out>) at ui/browsers/hists.c:340
> #5  perf_evsel__hists_browse (evsel=evsel@...ry=0x946950, nr_events=nr_events@...ry=1, 
>     helpline=helpline@...ry=0x57dc78 "For a higher level overview, try: perf top --sort comm,dso", 
>     ev_name=0x946c60 "cycles", left_exits=left_exits@...ry=false, hbt=hbt@...ry=0x7fffeaf49ea0, 
>     min_pcnt=min_pcnt@...ry=0, env=env@...ry=0x947000) at ui/browsers/hists.c:1430
> #6  0x00000000004cd425 in perf_evlist__tui_browse_hists (evlist=0x8e6840, 
>     help=help@...ry=0x57dc78 "For a higher level overview, try: perf top --sort comm,dso", 
>     hbt=hbt@...ry=0x7fffeaf49ea0, min_pcnt=0, env=0x947000) at ui/browsers/hists.c:1959
> #7  0x0000000000433928 in display_thread_tui (arg=0x7fffffffb270) at builtin-top.c:581
> #8  0x00000031c5407c53 in start_thread (arg=0x7fffeaf4a700) at pthread_create.c:308
> #9  0x00000031c48f5dbd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:113
> (gdb) 

Looks like not directly related to the log window.. maybe it already
corrupted some memory regions.

One thing I can think of is the perf_log.linemap was reallocated but the
log window accessed an old linemap.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/