lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1529.1387873722@ale.ozlabs.ibm.com>
Date:	Tue, 24 Dec 2013 19:28:42 +1100
From:	Michael Neuling <michael.neuling@....ibm.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Michael Neuling <michael@...ling.org>,
	Nishanth Aravamudan <nacc@...ux.vnet.ibm.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] auxvec.h: account for AT_HWCAP2 in AT_VECTOR_SIZE_BASE

> Please cc the guilty parties when sending patches like this.

Crud, sorry about that.

Can we add a comment at the end of include/linux/auxvec.h that says you
need to update this?  Then plebs like me are less likely to miss it in
future.

Mikey

> Also, just out of interest, please describe how this bug affected
> things. Did we overflow the saved_auxv[] array, or what? Also, how
> does this change affect architectures that _don't_ have that
> ELF_HWCAP2 thing, ie everything but powerpc?
> 
> Acks, people?
> 
>            Linus
> 
> On Mon, Dec 23, 2013 at 9:49 AM, Ard Biesheuvel
> <ard.biesheuvel@...aro.org> wrote:
> > Commit 2171364d1a92 (powerpc: Add HWCAP2 aux entry) introduced a new
> > AT_ auxv entry type AT_HWCAP2 but failed to update AT_VECTOR_SIZE_BASE
> > accordingly.
> >
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> > Fixes: 2171364d1a92 (powerpc: Add HWCAP2 aux entry)
> > Cc: stable@...r.kernel.org
> > ---
> >
> >  include/linux/auxvec.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/auxvec.h b/include/linux/auxvec.h
> > index 669fef5..3e0fbe4 100644
> > --- a/include/linux/auxvec.h
> > +++ b/include/linux/auxvec.h
> > @@ -3,6 +3,6 @@
> >
> >  #include <uapi/linux/auxvec.h>
> >
> > -#define AT_VECTOR_SIZE_BASE 19 /* NEW_AUX_ENT entries in auxiliary table */
> > +#define AT_VECTOR_SIZE_BASE 20 /* NEW_AUX_ENT entries in auxiliary table */
> >    /* number of "#define AT_.*" above, minus {AT_NULL, AT_IGNORE, AT_NOTELF} */
> >  #endif /* _LINUX_AUXVEC_H */
> > --
> > 1.8.3.2
> >
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ