linux-kernel - Re: [PATCH v5 1/3] regulator: act8865: add PMIC act8865 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131224135127.GC24814@sirena.org.uk>
Date:	Tue, 24 Dec 2013 13:51:27 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Wenyou Yang <wenyou.yang@...el.com>
Cc:	lgirdwood@...il.com, grant.likely@...aro.org,
	rob.herring@...xeda.com, plagnioj@...osoft.com,
	nicolas.ferre@...el.com, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 1/3] regulator: act8865: add PMIC act8865 driver

On Tue, Dec 24, 2013 at 10:34:28AM +0800, Wenyou Yang wrote:
> Signed-off-by: Wenyou Yang <wenyou.yang@...el.com>

I've applied this, however there is one small issue which I seem to have
forgotten to point out previously:

> +	/* Finally register devices */
> +	for (i = 0; i < pdata->num_regulators; i++) {

The driver should register all regulators regardless of how many are
used in the system in order to aid diagnostics.  Please send an
incremental patch to fix this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/