[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <52B8F678.2090604@hitachi.com>
Date: Tue, 24 Dec 2013 11:50:32 +0900
From: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@...achi.com>
To: Kay Sievers <kay@...y.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
Eiichi Tsukata <eiichi.tsukata.xh@...achi.com>,
Frederic Weisbecker <fweisbec@...il.com>,
Tejun Heo <tj@...nel.org>, yrl.pp-manager.tt@...achi.com,
Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
Joe Perches <joe@...ches.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>
Subject: Re: Re: [PATCH 0/2] [BUGFIX] printk: Fix message continuation
breakage involved with structured printk
Hi Kay,
Thank you for replying me.
(2013/12/20 20:29), Kay Sievers wrote:
> On Fri, Dec 20, 2013 at 10:41 AM, Yoshihiro YUNOMAE
> <yoshihiro.yunomae.ez@...achi.com> wrote:
>
>> This patch set fixes message continuation breakage involved with structured
>> printk. A SCSI driver may output two continuation error messages like
>> scmd_printk("foo");
>> printf("bar\n");
>
> Which is the absolutely wrong thing to do. Structured logging and racy
> printk continuation must never be mixed. Userspace needs to be sure
> that dictionary entries are not subject to racy continuation hackery,
> and that these mwssages atomic, whole and intact.
I see.
As you say, user tools need to support messages output in multiple lines
for SMP environments even if this patch set is introduced.
> Please do not mix the both and do not apply these patches.
OK, I'll make important messages with KERN_CONT or no-prefix printk()
output those in single line.
Thanks,
Yoshihiro YUNOMAE
--
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: yoshihiro.yunomae.ez@...achi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists