linux-kernel - Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131224025059.GA24419@gchen.bj.intel.com>
Date:	Mon, 23 Dec 2013 21:51:00 -0500
From:	"Chen, Gong" <gong.chen@...ux.intel.com>
To:	Prarit Bhargava <prarit@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Michel Lespinasse <walken@...gle.com>,
	Seiji Aguchi <seiji.aguchi@....com>,
	Yang Zhang <yang.z.zhang@...el.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Janet Morgan <janet.morgan@...el.com>,
	Tony Luck <tony.luck@...el.com>,
	Ruiv Wang <ruiv.wang@...il.com>,
	Andi Kleen <ak@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...ux.intel.com>, x86@...nel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] x86, irq, fix logical AND/OR error in
 check_irq_vectors_for_cpu_disable()

On Mon, Dec 23, 2013 at 09:39:12AM -0500, Prarit Bhargava wrote:
> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> index 7d40698..aed7acc 100644
> --- a/arch/x86/kernel/irq.c
> +++ b/arch/x86/kernel/irq.c
> @@ -281,7 +281,7 @@ int check_irq_vectors_for_cpu_disable(void)
>  			desc = irq_to_desc(irq);
>  			data = irq_desc_get_irq_data(desc);
>  			affinity = data->affinity;
> -			if (irq_has_action(irq) || !irqd_is_per_cpu(data) ||
> +			if (irq_has_action(irq) && !irqd_is_per_cpu(data) &&
>  			    !cpumask_subset(affinity, cpu_online_mask))
>  				this_count++;
Hi, Prarit

I noticed that you don't mention another question I asked in last mail.

"It looks like cpu_online_mask will be updated until cpu_disable_common
is called, but your check_vectors is called before that."

native_cpu_disable
        cpu_disable_common
                remove_cpu_from_maps
                        /*
                         * until here, cpu_online_mask/cpu_online_bits
                         * is cleared
                         */
                        set_cpu_online(cpu, false);

Something I missed?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)