linux-kernel - [PATCH v2] regulator: act8865: Remove unneeded regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 25 Dec 2013 08:25:14 +0800
From:	Axel Lin <axel.lin@...ics.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Wenyou Yang <wenyou.yang@...el.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH v2] regulator: act8865: Remove unneeded
 regulator_unregister() calls

This is not required because current code uses devm_regulator_register() to
register regulators.

Signed-off-by: Axel Lin <axel.lin@...ics.com>
---
v2: Fix typo in subject line s/Rmove/Remove/
 drivers/regulator/act8865-regulator.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c
index db048f2..dfae294 100644
--- a/drivers/regulator/act8865-regulator.c
+++ b/drivers/regulator/act8865-regulator.c
@@ -334,17 +334,6 @@ static int act8865_pmic_probe(struct i2c_client *client,
 	return 0;
 }
 
-static int act8865_pmic_remove(struct i2c_client *client)
-{
-	struct act8865 *act8865 = i2c_get_clientdata(client);
-	int i;
-
-	for (i = 0; i < ACT8865_REG_NUM; i++)
-		regulator_unregister(act8865->rdev[i]);
-
-	return 0;
-}
-
 static const struct i2c_device_id act8865_ids[] = {
 	{ "act8865", 0 },
 	{ },
@@ -357,7 +346,6 @@ static struct i2c_driver act8865_pmic_driver = {
 		.owner	= THIS_MODULE,
 	},
 	.probe		= act8865_pmic_probe,
-	.remove		= act8865_pmic_remove,
 	.id_table	= act8865_ids,
 };
 
-- 
1.8.1.2



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/