linux-kernel - Re: [CRIU] [PATCH] timerfd: show procfs fdinfo helper

Open Source and information security mailing list archives

Message-ID: <CANaxB-xmF7uQSr_Xq63nTNTekVUb6RCKfYBEV_uNV5cgysx-qg@mail.gmail.com>
Date:	Wed, 25 Dec 2013 12:47:08 +0400
From:	Andrey Wagin <avagin@...il.com>
To:	Shawn Landden <shawn@...rchofgit.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"criu@...nvz.org" <criu@...nvz.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [CRIU] [PATCH] timerfd: show procfs fdinfo helper

2013/12/24 Shawn Landden <shawn@...rchofgit.com>:
> | pos:  0
> | flags:        02004002
> | clockid:      0
>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Alexander Viro <viro@...iv.linux.org.uk>
> Signed-off-by: Shawn Landden <shawn@...rchofgit.com>
> ---
>  fs/timerfd.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/fs/timerfd.c b/fs/timerfd.c
> index 9293121..e5fa587 100644
> --- a/fs/timerfd.c
> +++ b/fs/timerfd.c
> @@ -25,6 +25,7 @@
>  #include <linux/syscalls.h>
>  #include <linux/compat.h>
>  #include <linux/rcupdate.h>
> +#include <linux/seq_file.h>
>
>  struct timerfd_ctx {
>         union {
> @@ -284,7 +285,23 @@ static ssize_t timerfd_read(struct file *file, char __user *buf, size_t count,
>         return res;
>  }
>
> +#ifdef CONFIG_PROC_FS
> +static int timerfd_show_fdinfo(struct seq_file *m, struct file *f)
> +{
> +       struct timerfd_ctx *ctx = f->private_data;
> +       int clockid;
> +
> +       clockid = ctx->clockid;
> +       seq_printf(m, "clockid:\t%d\n", clockid);

I think we can show ctx->ticks, itimerspec here. The ctx->ticks is
required for proper dumping and restoring timerfd.

> +
> +       return 0;
> +}
> +#endif
> +
>  static const struct file_operations timerfd_fops = {
> +#ifdef CONFIG_PROC_FS
> +       .show_fdinfo    = timerfd_show_fdinfo,
> +#endif
>         .release        = timerfd_release,
>         .poll           = timerfd_poll,
>         .read           = timerfd_read,
> --
> 1.8.5.2.297.g3e57c29
>
> _______________________________________________
> CRIU mailing list
> CRIU@...nvz.org
> https://lists.openvz.org/mailman/listinfo/criu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives