linux-kernel - question about drivers/rtc/rtc-cmos.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1312252028170.2020@localhost6.localdomain6>
Date:	Wed, 25 Dec 2013 20:32:12 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	a.zummo@...ertech.it, grant.likely@...aro.org, robh+dt@...nel.org,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: question about drivers/rtc/rtc-cmos.c

The function cmos_do_probe contains the code:

		if (is_hpet_enabled()) {
                        int err;

                        rtc_cmos_int_handler = hpet_rtc_interrupt;
			err = hpet_register_irq_handler(cmos_interrupt);
                        if (err != 0) {
                                dev_warn(dev, "hpet_register_irq_handler "
                                                " failed in rtc_init().");
                                goto cleanup1;
                        }
                }

Is it intentional that the error code returned by 
hpet_register_irq_handler is put ina local variable that will not be seen 
at label cleanup1?  The return value is retval, which is 0 at this point.

thanks,
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/