linux-kernel - RE: [PATCH] usb/core: fix NULL pointer dereference in recursively_mark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0C18FE92A7765D4EB9EE5D38D86A563A01A3190F@SHSMSX103.ccr.corp.intel.com>
Date:	Thu, 26 Dec 2013 02:11:54 +0000
From:	"Du, ChangbinX" <changbinx.du@...el.com>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"sarah.a.sharp@...ux.intel.com" <sarah.a.sharp@...ux.intel.com>,
	"Lan, Tianyu" <tianyu.lan@...el.com>,
	"burzalodowa@...il.com" <burzalodowa@...il.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb/core: fix NULL pointer dereference in
 recursively_mark_NOTATTACHED

> On Tue, 24 Dec 2013, Alan Stern wrote:
> I think this will fix it.  Take a close look and do some careful testing.
> 
> Alan Stern
> 
> Index: usb-3.13/drivers/usb/core/hub.c
> ==========================================================
> =========
> --- usb-3.13.orig/drivers/usb/core/hub.c
> +++ usb-3.13/drivers/usb/core/hub.c
> @@ -1622,11 +1622,14 @@ static void hub_disconnect(struct usb_in
>  	hub->error = 0;
>  	hub_quiesce(hub, HUB_DISCONNECT);
> 
> -	usb_set_intfdata (intf, NULL);
> -
>  	for (i = 0; i < hdev->maxchild; i++)
>  		usb_hub_remove_port_device(hub, i + 1);
> +
> +	/* Avoid races with recursively_mark_NOTATTACHED() */
> +	spin_lock_irq(&device_state_lock);
>  	hub->hdev->maxchild = 0;
> +	usb_set_intfdata(intf, NULL);
> +	spin_unlock_irq(&device_state_lock);
> 
>  	if (hub->hdev->speed == USB_SPEED_HIGH)
>  		highspeed_hubs--;
> 

Sorry for late response. Agree with you. I will test your patch carefully and 
let you know the result. Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/