linux-kernel - Re: [PATCH -tip v2 1/2] [CLEANUP] perf-probe: Expand given path to absolute path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131226142248.GE30980@ghostprotocols.net>
Date:	Thu, 26 Dec 2013 11:22:48 -0300
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	David Ahern <dsahern@...il.com>
Cc:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Ingo Molnar <mingo@...nel.org>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	lkml <linux-kernel@...r.kernel.org>,
	"Steven Rostedt (Red Hat)" <rostedt@...dmis.org>,
	Oleg Nesterov <oleg@...hat.com>,
	"David A. Long" <dave.long@...aro.org>, systemtap@...rceware.org,
	yrl.pp-manager.tt@...achi.com, Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH -tip v2 1/2] [CLEANUP] perf-probe: Expand given path to
 absolute path

Em Thu, Dec 26, 2013 at 09:14:46AM -0500, David Ahern escreveu:
> On 12/26/13, 12:41 AM, Masami Hiramatsu wrote:
> >@@ -180,7 +181,20 @@ static int opt_set_target(const struct option *opt, const char *str,
> >  		else
> >  			return ret;
> >
> >-		params.target = str;
> >+		/* Expand given path to absolute path, except for modulename */
> >+		if (params.uprobes || strchr(str, '/')) {
> >+			tmp = realpath(str, NULL);
> >+			if (!tmp) {
> >+				pr_warning("Failed to find the path of %s.\n",
> >+					   str);
> 
> That error message will be misleading if it is generated. How about:
>     Failed to get the absolute path of %s: %d\n", str, errno.

Changed it to:

 pr_warning("Failed to get the absolute path of %s: %m\n", str);

 
> >+				return ret;
> >+			}
> >+		} else {
> >+			tmp = strdup(str);
> >+			if (!tmp)
> >+				return -ENOMEM;
> >+		}
> >+		params.target = tmp;
> 
> When is params.target freed?

> David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/