linux-kernel - Re: [PATCH] Use __kernel_long_t in struct mq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMe9rOoS4qMmTyyHvv2xq1zyFuKFk=++kfx7mM_CGhS-b8fTkA@mail.gmail.com>
Date:	Thu, 26 Dec 2013 09:59:53 -0800
From:	"H.J. Lu" <hjl.tools@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Use __kernel_long_t in struct mq_attr

On Thu, Dec 26, 2013 at 9:53 AM, H. Peter Anvin <hpa@...or.com> wrote:
> On 12/26/2013 07:54 AM, H.J. Lu wrote:
>> On Wed, Dec 25, 2013 at 08:58:34AM -0800, H.J. Lu wrote:
>>> Both x32 and x86-64 use the same struct mq_attr for system calls.  But
>>> x32 long is 32-bit. This patch replaces long with __kernel_long_t in
>>> struct mq_attr.
>>>
>>
>> Here is the updated patch which uses __kernel_long_t only if
>> __BITS_PER_LONG == 64.
>>
>
> That seems wrong in multiple ways... not only does it add more clutter,

It is true for more clutter.

> but it would seem to give the wrong types when __BITS_PER_LONG in
> userspace is 32.
>

For x32,  __BITS_PER_LONG is 64, not 32. If __BITS_PER_LONG
 is 32, my patch doesn't change anything.  If it works before,
it still works.  If it is broken before, it remains broken.

I prefer my first patch, which is less clutter.  But I can't guarantee
it is correct for all x3-like ABIs.  My second patch has more
clutter, but it has no impact on other ABIs.

-- 
H.J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/