[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <000801cf0213$f40bec50$dc23c4f0$%han@samsung.com>
Date: Thu, 26 Dec 2013 17:24:53 +0900
From: Jingoo Han <jg1.han@...sung.com>
To: 'Josh Triplett' <josh@...htriplett.org>
Cc: 'David Woodhouse' <dwmw2@...radead.org>,
'Brian Norris' <computersforpeace@...il.com>,
linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
'Jingoo Han' <jg1.han@...sung.com>,
'Dinh Nguyen' <dinguyen@...era.com>
Subject: Re: [PATCH 1/7] mtd: denali: Drop print of build date/time
On Tuesday, December 24, 2013 6:55 AM, Josh Triplett wrote:
>
> The kernel already has this information, and individual drivers
> shouldn't duplicate that. This also eliminates the use of __DATE__ and
> __TIME__, which make the build non-deterministic.
>
> Signed-off-by: Josh Triplett <josh@...htriplett.org>
(+cc Dinh Nguyen)
It looks good. :-)
Reviewed-by: Jingoo Han <jg1.han@...sung.com>
Best regards,
Jingoo Han
> ---
> drivers/mtd/nand/denali_pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/denali_pci.c b/drivers/mtd/nand/denali_pci.c
> index 033f177..ab64416 100644
> --- a/drivers/mtd/nand/denali_pci.c
> +++ b/drivers/mtd/nand/denali_pci.c
> @@ -131,7 +131,6 @@ static struct pci_driver denali_pci_driver = {
>
> static int denali_init_pci(void)
> {
> - pr_info("Spectra MTD driver built on %s @ %s\n", __DATE__, __TIME__);
> return pci_register_driver(&denali_pci_driver);
> }
> module_init(denali_init_pci);
> --
> 1.8.5.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists