linux-kernel - Re: [PATCH 1/1] reiserfs:Adding tmpfile support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131226090203.GA17995@infradead.org>
Date:	Thu, 26 Dec 2013 01:02:03 -0800
From:	Christoph Hellwig <hch@...radead.org>
To:	Richard Weinberger <richard.weinberger@...il.com>
Cc:	Fabian Frederick <fabf@...net.be>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Jeff Mahoney <jeffm@...e.com>, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH 1/1] reiserfs:Adding tmpfile support

On Wed, Dec 25, 2013 at 02:39:48PM +0100, Richard Weinberger wrote:
> On Wed, Dec 25, 2013 at 2:23 PM, Fabian Frederick <fabf@...net.be> wrote:
> > This patch is largely based on reiserfs_create function.
> > -Removing dquot_initialize (cf ext2/tmpfile)
> > -Removing add_entry code.
> > -Adding d_tmpfile generic call.
> >
> > It was not extensively tested; other solutions would
> > be to work with hidden entries or merge
> > creation - tmpfile process.
> 
> Is it worth adding new features to a legacy file system like reiserfs?

Having user API parity is always a good thing, especially if it doesn't
require on-disk format changes.  Same case as FIEMAP or
SEEK_DATA/SEEK_HOLE to mention some recent features.

That being said this needs to follow them model of ext3/ext3/xfs and
add the inode to the unlink/orphan inode list on tmpfile creation and
move it out on flink.

We'll also need a proper verifier for the expected behaviour, which I
hope we'll get out of the work in progress XFS support.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/