linux-kernel - Re: [PATCH] Staging: tidspbridge: Use hashtable implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131227094532.GA17143@amd.pavel.ucw.cz>
Date:	Fri, 27 Dec 2013 10:45:32 +0100
From:	Pavel Machek <pavel@....cz>
To:	Ivaylo DImitrov <ivo.g.dimitrov.75@...il.com>
Cc:	gregkh@...uxfoundation.org, omar.ramirez@...itl.com,
	pali.rohar@...il.com, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org, Ivaylo Dimitrov <freemangordon@....bg>
Subject: Re: [PATCH] Staging: tidspbridge: Use hashtable implementation

Hi!

> From: Ivaylo Dimitrov <freemangordon@....bg>
> 
> Use upstream hashtable implementation instead of generic code
> 
> Signed-off-by: Ivaylo Dimitrov <freemangordon@....bg>

> @@ -991,8 +989,11 @@ static struct dynload_symbol *dbll_add_to_symbol_table(struct dynamic_loader_sym
>  		sym_ptr =
>  		    (struct dbll_symbol *)gh_insert(lib->sym_tab, (void *)name,
>  						    (void *)&symbol);
> -		if (sym_ptr == NULL)
> +		if (IS_ERR(sym_ptr))
> +		{

You want this { to go to the previous line. Otherwise looks good,

Reviewed-by: Pavel Machek <pavel@....cz>

Thanks,

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/