linux-kernel - Re: [PATCH v4 01/15] usb: phy: msm: Move mach dependent code to platform data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131227184434.GG7819@saruman.home>
Date:	Fri, 27 Dec 2013 12:44:34 -0600
From:	Felipe Balbi <balbi@...com>
To:	Stephen Boyd <sboyd@...eaurora.org>
CC:	<balbi@...com>, "Ivan T. Ivanov" <iivanov@...sol.com>,
	<gregkh@...uxfoundation.org>, <rob.herring@...xeda.com>,
	<pawel.moll@....com>, <mark.rutland@....com>,
	<swarren@...dotorg.org>, <ijc+devicetree@...lion.org.uk>,
	<davidb@...eaurora.org>, <linux-usb@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Daniel Walker <dwalker@...o99.com>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v4 01/15] usb: phy: msm: Move mach dependent code to
 platform data

On Fri, Dec 27, 2013 at 10:23:10AM -0800, Stephen Boyd wrote:
> On 12/27/13 10:10, Felipe Balbi wrote:
> > Hi,
> >
> > On Tue, Nov 12, 2013 at 04:51:36PM +0200, Ivan T. Ivanov wrote:
> >> From: "Ivan T. Ivanov" <iivanov@...sol.com>
> >>
> >> This patch fix compilation error when driver is compiled
> >> in multi-platform builds.
> >>
> >> drivers/built-in.o: In function `msm_otg_link_clk_reset':
> >> ./drivers/usb/phy/phy-msm-usb.c:314: undefined reference to `clk_reset'
> >> ./drivers/usb/phy/phy-msm-usb.c:318: undefined reference to `clk_reset'
> >>
> >> Use platform data supplied reset handlers and adjust error
> >> messages reported when reset sequence fail.
> >>
> >> This is an intermediate step before adding support for reset
> >> framework and newer targets.
> >>
> >> Signed-off-by: Ivan T. Ivanov <iivanov@...sol.com>
> >> Acked-by: David Brown <davidb@...eaurora.org>
> >> Cc: Daniel Walker <dwalker@...o99.com>
> >> Cc: Felipe Balbi <balbi@...com>
> >> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > this really looks like you should be using reset framework
> > (drivers/reset/), then your phy driver would simply reset_assert() and
> > reset_deassert().
> >
> 
> Unfortunately the reset framework is a DT only framework and there are
> still non-DT platforms within mach-msm. Arnd suggested we push the
> non-DT reset code down into the mach directory in the meantime. We're in
> the process of adding the reset framework to DT enabled MSM platforms,
> hopefully those get merged in 3.14.

And this is why the ARM port is in such a messy situation. It's always
better to "push things into the mach- directory" than improving existing
frameworks to cope with wild ARM SoCs.

fell free to push this through your tree. It _does_ make the PHY driver
slightly better and probably buildable on other arches with
COMPILE_TEST.

Still, I *really* want to see this switching over to reset framework on
v3.16.

cheers

ps: for this patch only you can have my

Acked-by: Felipe Balbi <balbi@...com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)