linux-kernel - Re: question about drivers/rtc/rtc-cmos.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1312272124180.2018@localhost6.localdomain6>
Date:	Fri, 27 Dec 2013 21:26:14 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Alessandro Zummo <a.zummo@...ertech.it>
cc:	Julia Lawall <julia.lawall@...6.fr>, grant.likely@...aro.org,
	robh+dt@...nel.org, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org
Subject: Re: question about drivers/rtc/rtc-cmos.c

On Fri, 27 Dec 2013, Alessandro Zummo wrote:

> On Wed, 25 Dec 2013 20:32:12 +0100 (CET)
> Julia Lawall <julia.lawall@...6.fr> wrote:
> 
> 
> > Is it intentional that the error code returned by 
> > hpet_register_irq_handler is put ina local variable that will not be seen 
> > at label cleanup1?  The return value is retval, which is 0 at this point.
> 
>   Well, I'd say it's an error. Did you got it by hand
>   or with one of your tools? ;)

Coccinelle.  No idea if it an happen in real life.

I will drop err and replace it by retval.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/