linux-kernel - Re: [PATCH 1/5] sched, rt: move .switched_from out of the scope of CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131228091948.GA3832@HP-250-G1-Notebook-PC.beeline>
Date:	Sat, 28 Dec 2013 13:19:48 +0400
From:	Kirill Tkhai <tkhai@...dex.ru>
To:	Zhi Yong Wu <zwu.kernel@...il.com>
Cc:	mingo@...hat.com, peterz@...radead.org,
	linux-kernel@...r.kernel.org,
	Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
Subject: Re: [PATCH 1/5] sched, rt: move .switched_from out of the scope of
 CONFIG_SMP

On Пт, дек 27, 2013 at 07:41:00 +0800, Zhi Yong Wu wrote:
> From: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
> 
> .switched_from shouldn't be initialized in the scope of CONFIG_SMP,
> so this patch is trying to move it out.
> 
> Signed-off-by: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
> ---
>  kernel/sched/rt.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 1c40655..f34d41b 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -2002,9 +2002,9 @@ const struct sched_class rt_sched_class = {
>  	.pre_schedule		= pre_schedule_rt,
>  	.post_schedule		= post_schedule_rt,
>  	.task_woken		= task_woken_rt,
> -	.switched_from		= switched_from_rt,
>  #endif
>  
> +	.switched_from		= switched_from_rt,
>  	.set_curr_task          = set_curr_task_rt,
>  	.task_tick		= task_tick_rt,

This will not be compilable in !SMP mode because the body of switched_from_rt()
is still under CONFIG_SMP define.

Kirill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/