lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 28 Dec 2013 09:48:57 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Arthur Schwalbenberg <arthurs578@...il.com>
Cc:	john.stultz@...aro.org, dan.carpenter@...cle.com,
	cruzjbishop@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 	Staging: Android: Fixed coding issue return parenthesis
 in alarm_dev.c

On Sat, Dec 28, 2013 at 11:03:28AM -0500, Arthur Schwalbenberg wrote:
> 	This is a patch to the alarm_dev.c file that fixes up a return is not
> 	a function warning found by the checkpatch.pl tool
> 
> 	Signed-off-by: Arthur Schwalbenberg <arthurs578@...il.com>

Why the odd indentation?

> ---
>  drivers/staging/android/alarm-dev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/android/alarm-dev.c b/drivers/staging/android/alarm-dev.c
> index 647694f..96b2f53 100644
> --- a/drivers/staging/android/alarm-dev.c
> +++ b/drivers/staging/android/alarm-dev.c
> @@ -68,8 +68,8 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
>   */
>  static int is_wakeup(enum android_alarm_type type)
>  {
> -	return (type == ANDROID_ALARM_RTC_WAKEUP ||
> -		type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP);
> +	return type == ANDROID_ALARM_RTC_WAKEUP ||
> +	       type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP;
>  }

This change is already in linux-next, right?  I can't apply the same
change more than once to the tree...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists