linux-kernel - [PATCH 3.2 097/185] irq: Enable all irqs unconditionally in irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lsq.1388282924.763420580@decadent.org.uk>
Date:	Sun, 29 Dec 2013 03:08:44 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	linux-kernel@...r.kernel.org, stable@...r.kernel.org
CC:	akpm@...ux-foundation.org, "" <ian.campbell@...rix.com>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Pavel Machek" <pavel@....cz>, "" <gregkh@...uxfoundation.org>,
	"" <len.brown@...el.com>, "Heiko Stuebner" <heiko@...ech.de>,
	"" <rjw@...ysocki.net>, "Laxman Dewangan" <ldewangan@...dia.com>
Subject: [PATCH 3.2 097/185] irq: Enable all irqs unconditionally in
 irq_resume

3.2.54-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Laxman Dewangan <ldewangan@...dia.com>

commit ac01810c9d2814238f08a227062e66a35a0e1ea2 upstream.

When the system enters suspend, it disables all interrupts in
suspend_device_irqs(), including the interrupts marked EARLY_RESUME.

On the resume side things are different. The EARLY_RESUME interrupts
are reenabled in sys_core_ops->resume and the non EARLY_RESUME
interrupts are reenabled in the normal system resume path.

When suspend_noirq() failed or suspend is aborted for any other
reason, we might omit the resume side call to sys_core_ops->resume()
and therefor the interrupts marked EARLY_RESUME are not reenabled and
stay disabled forever.

To solve this, enable all irqs unconditionally in irq_resume()
regardless whether interrupts marked EARLY_RESUMEhave been already
enabled or not.

This might try to reenable already enabled interrupts in the non
failure case, but the only affected platform is XEN and it has been
confirmed that it does not cause any side effects.

[ tglx: Massaged changelog. ]

Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
Acked-by-and-tested-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Acked-by: Heiko Stuebner <heiko@...ech.de>
Reviewed-by: Pavel Machek <pavel@....cz>
Cc: <ian.campbell@...rix.com>
Cc: <rjw@...ysocki.net>
Cc: <len.brown@...el.com>
Cc: <gregkh@...uxfoundation.org>
Link: http://lkml.kernel.org/r/1385388587-16442-1-git-send-email-ldewangan@nvidia.com
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
---
 kernel/irq/pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/kernel/irq/pm.c
+++ b/kernel/irq/pm.c
@@ -50,7 +50,7 @@ static void resume_irqs(bool want_early)
 		bool is_early = desc->action &&
 			desc->action->flags & IRQF_EARLY_RESUME;

-		if (is_early != want_early)
+		if (!is_early && want_early)
 			continue;

 		raw_spin_lock_irqsave(&desc->lock, flags);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/