linux-kernel - Re: [PATCH v5 3/3] perf diff: color the Weighted Diff column

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALkWK0kXNJfqDcM30GEmZNDEKt5oBp571S1edwayH-GY9mOkKA@mail.gmail.com>
Date:	Sun, 29 Dec 2013 15:44:38 +0530
From:	Ramkumar Ramachandra <artagnon@...il.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH v5 3/3] perf diff: color the Weighted Diff column

Jiri Olsa wrote:
> this one is still wrong, you either need to use 'abs(wdiff) > 0'
> or call value_color_snprintf (which is better) as in previous cases

This was very much intentional on my part (see commit message): I
thought it would be nicer to color it this way because all the numbers
tend to be large. However, I'll resubmit with value_color_snprintf()
now.

p.s- Sorry about the terribly late response; was on vacation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/