linux-kernel - Re: [PATCH] mm: dump page when hitting a VM_BUG_ON using VM_BUG_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131230104854.GA7647@node.dhcp.inet.fi>
Date:	Mon, 30 Dec 2013 12:48:54 +0200
From:	"Kirill A. Shutemov" <kirill@...temov.name>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: dump page when hitting a VM_BUG_ON using
 VM_BUG_ON_PAGE fix

On Fri, Dec 27, 2013 at 05:40:18PM -0500, Sasha Levin wrote:
> I messed up and forgot to commit this fix before sending out the original
> patch.
> 
> It fixes build issues in various files using VM_BUG_ON_PAGE.

With the patch applied I see this:

  CC      kernel/bounds.s
In file included from /home/space/kas/git/public/linux-next/include/linux/page-flags.h:10:0,
                 from /home/space/kas/git/public/linux-next/kernel/bounds.c:9:
/home/space/kas/git/public/linux-next/include/linux/mmdebug.h:5:30: warning: ‘struct page’ declared inside parameter list [enabled by default]
 extern void dump_page(struct page *page);
                              ^
/home/space/kas/git/public/linux-next/include/linux/mmdebug.h:5:30: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

We need to declare struct page here as well.

diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
index 8bb64900da25..e8cec8bdda05 100644
--- a/include/linux/mmdebug.h
+++ b/include/linux/mmdebug.h
@@ -2,6 +2,7 @@
 #define LINUX_MM_DEBUG_H 1
 
 #ifdef CONFIG_DEBUG_VM
+struct page;
 extern void dump_page(struct page *page);
 #define VM_BUG_ON(cond) BUG_ON(cond)
 #define VM_BUG_ON_PAGE(cond, page) \
-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/