linux-kernel - Re: [PATCH net-next v2 11/20] net: packetengines: slight optimization of addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1388383526.26796.21.camel@joe-AO722>
Date:	Sun, 29 Dec 2013 22:05:26 -0800
From:	Joe Perches <joe@...ches.com>
To:	Ding Tianhong <dingtianhong@...wei.com>
Cc:	Ding Tianhong <dthxman@...il.com>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	"David S. Miller" <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 11/20] net: packetengines: slight
 optimization of addr

On Mon, 2013-12-30 at 10:39 +0800, Ding Tianhong wrote:
> I don't understand packetengine NIC anymore, But I think the change is clearly,
> as your said, the broadcast check is enough here, did you mean that?
> 
> 	!is_broadcast_ether_addr((u8 *)(le32_to_cpu(yp->rx_ring_dma) +
> 						    entry * sizeof(struct yellowfin_desc)))

Not quite.  I meant this could be:

		u8 *addr = (u8 *)(unsigned long)le32_to_cpu(yp->rx_ring_dma) +
							    entry * sizeof(struct yellowfin_desc);

		if (!ether_addr_equal(addr, dev->dev_addr) &&
		    !is_broadcast_ether_addr(addr)) {
			etc...

but again, I think thus hardly matters and could just as well
be left alone.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/