linux-kernel - Re: [PATCH net-next v3 04/19] net: enic: slight optimization of addr compare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.03.1312301341050.2286@cisco.com>
Date:	Mon, 30 Dec 2013 13:42:18 +0530 (IST)
From:	Govindarajulu Varadarajan <gvaradar@...co.com>
To:	Ding Tianhong <dingtianhong@...wei.com>
cc:	Christian Benvenuti <benve@...co.com>,
	Sujith Sankar <ssujith@...co.com>,
	Govindarajulu Varadarajan <govindarajulu90@...il.com>,
	Neel Patel <neepatel@...co.com>,
	Nishank Trivedi <nistrive@...co.com>,
	"David S. Miller" <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v3 04/19] net: enic: slight optimization of addr
 compare

On Mon, 30 Dec 2013, Ding Tianhong wrote:

> Use possibly more efficient ether_addr_equal
> to instead of memcmp.
>
> Cc: Christian Benvenuti <benve@...co.com>
> Cc: Sujith Sankar <ssujith@...co.com>
> Cc: Govindarajulu Varadarajan <govindarajulu90@...il.com>
> Cc: Neel Patel <neepatel@...co.com>
> Cc: Nishank Trivedi <nistrive@...co.com>
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>
> ---
> drivers/net/ethernet/cisco/enic/enic_pp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cisco/enic/enic_pp.c b/drivers/net/ethernet/cisco/enic/enic_pp.c
> index 43464f0..e6a8319 100644
> --- a/drivers/net/ethernet/cisco/enic/enic_pp.c
> +++ b/drivers/net/ethernet/cisco/enic/enic_pp.c
> @@ -162,7 +162,7 @@ static int enic_are_pp_different(struct enic_port_profile *pp1,
> 	return strcmp(pp1->name, pp2->name) | !!memcmp(pp1->instance_uuid,
> 		pp2->instance_uuid, PORT_UUID_MAX) |
> 		!!memcmp(pp1->host_uuid, pp2->host_uuid, PORT_UUID_MAX) |
> -		!!memcmp(pp1->mac_addr, pp2->mac_addr, ETH_ALEN);
> +		!ether_addr_equal(pp1->mac_addr, pp2->mac_addr);
> }
>
> static int enic_pp_preassociate(struct enic *enic, int vf,
> -- 
> 1.8.0
>

looks good for me

Acked-by: Govindarajulu Varadarajan <govindarajulu90@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/