linux-kernel - Re: [PATCH] ASoC: simple-card: Cleanup __asoc_simple_card_dai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131231124945.GU31886@sirena.org.uk>
Date:	Tue, 31 Dec 2013 12:49:45 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Xiubo Li <Li.Xiubo@...escale.com>
Cc:	lgirdwood@...il.com, rob@...dley.net,
	kuninori.morimoto.gx@...esas.com, fabio.estevam@...escale.com,
	alsa-devel@...a-project.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: simple-card: Cleanup __asoc_simple_card_dai_init()
 ret check

On Mon, Dec 23, 2013 at 01:24:59PM +0800, Xiubo Li wrote:
> The ret parameter is always equal to zero till here.

Applied, thanks.  This is on the edge of what's a good cleanup - it's
a taste thing if it's better to have every call be the same so the code
looks more regular or if it's better to have the redundant test removed.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)