linux-kernel - Re: [PATCH 1/11] rt2x00: use ether_addr_equal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DF2F19A7-DC12-44CE-8488-9BCC92A23D84@gmail.com>
Date:	Tue, 31 Dec 2013 17:44:03 +0100
From:	Gertjan van Wingerde <gwingerde@...il.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	Ivo van Doorn <IvDoorn@...il.com>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	Helmut Schaa <helmut.schaa@...glemail.com>,
	"John W. Linville" <linville@...driver.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"users@...x00.serialmonkey.com" <users@...x00.serialmonkey.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/11] rt2x00: use ether_addr_equal_64bits



Sent from my iPad

> On 30 dec. 2013, at 19:14, Julia Lawall <Julia.Lawall@...6.fr> wrote:
> 
> From: Julia Lawall <Julia.Lawall@...6.fr>
> 
> Ether_addr_equal_64bits is more efficient than ether_addr_equal, and can be
> used when each argument is an array within a structure that contains at
> least two bytes of data beyond the array.
> 
> The structures involved are:
> ieee80211_bar defined in include/linux/ieee80211.h and
> rt2x00_bar_list_entry defined in drivers/net/wireless/rt2x00/rt2x00.h.
> 
> This was done using Coccinelle (http://coccinelle.lip6.fr/).
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Acked-by: Gertjan van Wingerde <gwingerde@...il.com>

> 
> ---
> The semantic patch used is rather long and can be found in message 0 of
> this patch series.
> 
> drivers/net/wireless/rt2x00/rt2x00dev.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index 00c3fae..2bde672 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -565,10 +565,10 @@ static void rt2x00lib_rxdone_check_ba(struct rt2x00_dev *rt2x00dev,
> 
> #undef TID_CHECK
> 
> -        if (!ether_addr_equal(ba->ra, entry->ta))
> +        if (!ether_addr_equal_64bits(ba->ra, entry->ta))
>            continue;
> 
> -        if (!ether_addr_equal(ba->ta, entry->ra))
> +        if (!ether_addr_equal_64bits(ba->ta, entry->ra))
>            continue;
> 
>        /* Mark BAR since we received the according BA */
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/