linux-kernel - Re: [PATCH 0/2] input: mt: Add helper function to send end events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131231185035.GD6897@core.coreip.homeip.net>
Date:	Tue, 31 Dec 2013 10:50:36 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	"Felipe F. Tonello" <eu@...ipetonello.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] input: mt: Add helper function to send end events

Hi Henrik,

On Tue, Dec 31, 2013 at 10:26:31AM +0100, Henrik Rydberg wrote:
> Hi Felipe,
> 
> > Adds a helper function to send end touch events for active tracking ids.
> > And also implements it in egalax driver.
> 
> What problematic scenario is this supposed to solve?
> 
> The 'release on suspend' is only an approximation to the 'close
> laptop' scenario, it is certainly not correct in the coffee table
> case,

Why would it not be correct for coffee table? Do we expect the touches
to remain valid while the device is asleep?

> for instance. Instead of
> hardcoding this in the kernel, userland can easily detect long intervals
> directly using the event time.

But with slots it is not only problem with old events being sent out
later, it is that we have mix of old (pre-sleep) and new state.

> 
> Unless there is already a reasonable mechanism in your user
> application which deals with cases like this but fails to account for
> your particular problem scenario, the patch will not be applied.
> 

We do that for keys (release them when we transition to system sleep)
and I think it might be worthwhile to do the same for touch data.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/