linux-kernel - Re: [PATCH] Staging: rtl8188eu: Fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52C23C41.6090003@lwfinger.net>
Date:	Mon, 30 Dec 2013 21:38:41 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Tim Jester-Pfadt <t.jp@....de>, gregkh@...uxfoundation.org
CC:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8188eu: Fixed coding style issues

On 12/30/2013 08:53 PM, Tim Jester-Pfadt wrote:
> Fixed required and prohibited spaces to make rtw_io.h checkpatch.pl clean
>
> Signed-off-by: Tim Jester-Pfadt <t.jp@....de>
> ---
>   drivers/staging/rtl8188eu/include/rtw_io.h | 36 +++++++++++++++---------------
>   1 file changed, 18 insertions(+), 18 deletions(-)

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Larry

>
> diff --git a/drivers/staging/rtl8188eu/include/rtw_io.h b/drivers/staging/rtl8188eu/include/rtw_io.h
> index eb6f0e5..3d1dfcc 100644
> --- a/drivers/staging/rtl8188eu/include/rtw_io.h
> +++ b/drivers/staging/rtl8188eu/include/rtw_io.h
> @@ -123,7 +123,7 @@ struct _io_ops {
>   			  u8 *pmem);
>   	u32 (*_write_port)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt,
>   			   u8 *pmem);
> -	u32 (*_write_scsi)(struct intf_hdl *pintfhdl,u32 cnt, u8 *pmem);
> +	u32 (*_write_scsi)(struct intf_hdl *pintfhdl, u32 cnt, u8 *pmem);
>   	void (*_read_port_cancel)(struct intf_hdl *pintfhdl);
>   	void (*_write_port_cancel)(struct intf_hdl *pintfhdl);
>   };
> @@ -213,7 +213,7 @@ struct reg_protocol_wt {
>   	u32	Value;
>   #else
>   	/* DW1 */
> -	u32 Reserved1 :4;
> +	u32 Reserved1:4;
>   	u32 NumOfTrans:4;
>   	u32 Reserved2:24;
>   	/* DW2 */
> @@ -254,7 +254,7 @@ struct io_priv {
>   };
>
>   uint ioreq_flush(struct adapter *adapter, struct io_queue *ioqueue);
> -void sync_ioreq_enqueue(struct io_req *preq,struct io_queue *ioqueue);
> +void sync_ioreq_enqueue(struct io_req *preq, struct io_queue *ioqueue);
>   uint sync_ioreq_flush(struct adapter *adapter, struct io_queue *ioqueue);
>   uint free_ioreq(struct io_req *preq, struct io_queue *pio_queue);
>   struct io_req *alloc_ioreq(struct io_queue *pio_q);
> @@ -368,20 +368,20 @@ void free_io_queue(struct adapter *adapter);
>   void async_bus_io(struct io_queue *pio_q);
>   void bus_sync_io(struct io_queue *pio_q);
>   u32 _ioreq2rwmem(struct io_queue *pio_q);
> -void dev_power_down(struct adapter * Adapter, u8 bpwrup);
> -
> -#define PlatformEFIOWrite1Byte(_a,_b,_c)		\
> -	rtw_write8(_a,_b,_c)
> -#define PlatformEFIOWrite2Byte(_a,_b,_c)		\
> -	rtw_write16(_a,_b,_c)
> -#define PlatformEFIOWrite4Byte(_a,_b,_c)		\
> -	rtw_write32(_a,_b,_c)
> -
> -#define PlatformEFIORead1Byte(_a,_b)		\
> -		rtw_read8(_a,_b)
> -#define PlatformEFIORead2Byte(_a,_b)		\
> -		rtw_read16(_a,_b)
> -#define PlatformEFIORead4Byte(_a,_b)		\
> -		rtw_read32(_a,_b)
> +void dev_power_down(struct adapter *Adapter, u8 bpwrup);
> +
> +#define PlatformEFIOWrite1Byte(_a, _b, _c)		\
> +	rtw_write8(_a, _b, _c)
> +#define PlatformEFIOWrite2Byte(_a, _b, _c)		\
> +	rtw_write16(_a, _b, _c)
> +#define PlatformEFIOWrite4Byte(_a, _b, _c)		\
> +	rtw_write32(_a, _b, _c)
> +
> +#define PlatformEFIORead1Byte(_a, _b)		\
> +		rtw_read8(_a, _b)
> +#define PlatformEFIORead2Byte(_a, _b)		\
> +		rtw_read16(_a, _b)
> +#define PlatformEFIORead4Byte(_a, _b)		\
> +		rtw_read32(_a, _b)
>
>   #endif	/* _RTL8711_IO_H_ */
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/