lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 31 Dec 2013 09:52:34 +0200 From: Jack Morgenstein <jackm@....mellanox.co.il> To: Julia Lawall <Julia.Lawall@...6.fr> Cc: Roland Dreier <roland@...nel.org>, kernel-janitors@...r.kernel.org, Sean Hefty <sean.hefty@...el.com>, Hal Rosenstock <hal.rosenstock@...il.com>, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org, Or Gerlitz <ogerlitz@...lanox.com> Subject: Re: [PATCH 5/25] IB/mlx4: fix error return code On Sun, 29 Dec 2013 23:47:20 +0100 Julia Lawall <Julia.Lawall@...6.fr> wrote: > diff --git a/drivers/infiniband/hw/mlx4/sysfs.c > b/drivers/infiniband/hw/mlx4/sysfs.c index 97516eb..db2ea31 100644 > --- a/drivers/infiniband/hw/mlx4/sysfs.c > +++ b/drivers/infiniband/hw/mlx4/sysfs.c > @@ -582,8 +582,10 @@ static int add_port(struct mlx4_ib_dev *dev, int > port_num, int slave) p->pkey_group.attrs = > alloc_group_attrs(show_port_pkey, store_port_pkey, > dev->dev->caps.pkey_table_len[port_num]); > - if (!p->pkey_group.attrs) > + if (!p->pkey_group.attrs) { > + ret = -ENOMEM; > goto err_alloc; > + } > > ret = sysfs_create_group(&p->kobj, &p->pkey_group); > if (ret) > @@ -591,8 +593,10 @@ static int add_port(struct mlx4_ib_dev *dev, int > port_num, int slave) > p->gid_group.name = "gid_idx"; > p->gid_group.attrs = alloc_group_attrs(show_port_gid_idx, > NULL, 1); > - if (!p->gid_group.attrs) > + if (!p->gid_group.attrs) { > + ret = -ENOMEM; > goto err_free_pkey; > + } > ACK. Julia's patch is correct -- this is indeed a bug-fix. -Jack -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists