linux-kernel - Re: [PATCH v2 6/7] drm/msm: Drop unnecessary mach include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Dec 2013 20:19:11 -0500
From:	Rob Clark <robdclark@...il.com>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	arm@...nel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-arm-msm@...r.kernel.org,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	David Brown <davidb@...eaurora.org>,
	Dave Airlie <airlied@...hat.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v2 6/7] drm/msm: Drop unnecessary mach include

On Mon, Dec 30, 2013 at 8:12 PM, Rob Clark <robdclark@...il.com> wrote:
> On Mon, Dec 30, 2013 at 4:15 PM, Stephen Boyd <sboyd@...eaurora.org> wrote:
>> This file doesn't use the clk_reset() API that is exposed in
>> mach-msm's mach/clk.h file. Remove the include so that this
>> driver can be compiled as part of the multi-platform kernel.
>
> Thanks!
>
> Signed-off-by: Rob Clark <robdclark@...il.com>

oh, fwiw, things are a bit re-arranged on msm-next-staging (to add
8074 and 8060a support).. currently I have:

------------------
#if defined(CONFIG_ARCH_MSM)
#  include <mach/clk.h>
#elif defined(CONFIG_COMPILE_TEST)
/* stubs we need for compile-test: */
static inline struct device *msm_iommu_get_ctx(const char *ctx_name)
{
        return NULL;
}
#endif
------------------

Not really sure what to do about msm_iommu_get_ctx(), or whether I
still need that?

BR,
-R


>
>
>> Cc: Rob Clark <robdclark@...il.com>
>> Cc: Dave Airlie <airlied@...hat.com>
>> ---
>>  drivers/gpu/drm/msm/mdp4/mdp4_dtv_encoder.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/mdp4/mdp4_dtv_encoder.c b/drivers/gpu/drm/msm/mdp4/mdp4_dtv_encoder.c
>> index 5e0dcae..3799ccc 100644
>> --- a/drivers/gpu/drm/msm/mdp4/mdp4_dtv_encoder.c
>> +++ b/drivers/gpu/drm/msm/mdp4/mdp4_dtv_encoder.c
>> @@ -15,8 +15,6 @@
>>   * this program.  If not, see <http://www.gnu.org/licenses/>.
>>   */
>>
>> -#include <mach/clk.h>
>> -
>>  #include "mdp4_kms.h"
>>
>>  #include "drm_crtc.h"
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> hosted by The Linux Foundation
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/