linux-kernel - Re: [PATCH] Staging: bcm: Fixed excessive line lengths cleaned up some code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131231110127.GS28413@mwanda>
Date:	Tue, 31 Dec 2013 14:01:27 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Arthur Schwalbenberg <arthurs578@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	lisa@...apiadmin.com, linux-kernel@...r.kernel.org,
	himangi774@...il.com
Subject: Re: [PATCH] Staging: bcm: Fixed excessive line lengths cleaned up
 some code

On Mon, Dec 30, 2013 at 06:54:54AM -0500, Arthur Schwalbenberg wrote:
> 	This is a patch to the Adapter.h file that fixes up excesssive
> 	line length warnings found by the checkpatch.pl tool
> 
> 	Signed off by: Arthur Schwalbenberg <arthurs578@...il.com>

Don't indent the changelog like this.

Also the patch is wrong and breaks the driver.  You can't re-arrange
struct members which are a part of the user space API.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/