linux-kernel - Re: [PATCH] ASoC: generic: add generic compound card with DT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131231115927.GK31886@sirena.org.uk>
Date:	Tue, 31 Dec 2013 11:59:27 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Jean-Francois Moine <moinejf@...e.fr>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: generic: add generic compound card with DT support

On Tue, Dec 31, 2013 at 11:31:38AM +0100, Jean-Francois Moine wrote:

> This code was first developped on the generic simple card, but its
> recent DT extension cannot be easily extended again to support compound
> cards as the one in the Cubox.

It would have been useful to have provided that feedback at the time
rather than waiting until after it had been merged - it was in review
for long enough.  It would also be good to articulate the issues with
the binding rather than simply stating they exist, and to consider
adding a second binding to the existing generic card rather than adding
a totally new card.

Please also remember that all DT patches need to be reviewed by the DT
people, you've not CCed either them or the list.

> +  - front-end or back-end: present if the DAI link describes resp.
> +		a front-end CPU DAI or a back-end CODEC DAI

These are Linux-internal concepts which shouldn't appear in a DT binding
or at the very least need definition.  One thing to consider here is
that these things are all about the internals of a SoC and you'd
therefore expect that they would be defined separately from the card so
as to avoid having to replicate information in every card using a given
SoC.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)