linux-kernel - Re: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131231122036.GM31886@sirena.org.uk>
Date:	Tue, 31 Dec 2013 12:20:36 +0000
From:	Mark Brown <broonie@...nel.org>
To:	"Li.Xiubo@...escale.com" <Li.Xiubo@...escale.com>
Cc:	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"perex@...ex.cz" <perex@...ex.cz>,
	"shawn.guo@...aro.org" <shawn.guo@...aro.org>,
	"kuninori.morimoto.gx@...esas.com" <kuninori.morimoto.gx@...esas.com>,
	"Fabio.Estevam@...escale.com" <Fabio.Estevam@...escale.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of()
 code

On Tue, Dec 31, 2013 at 03:27:53AM +0000, Li.Xiubo@...escale.com wrote:

> Also, for most of the devices of the same DAI link, they use the same DAI
> formats, but I have found some drivers like : "sound/soc/pxa/magician.c"
> and "sound/soc/s6000/s6105-ipcam.c", etc, may have different DAI format
> settings for some reasons(maybe some formats are the CPU/Codec devices
> default setting that it needn't set it here or others).

The ipcam still has that?  It was supposed to have been fixed before it
was merged since it was identified as a bug in the CPU DAI during review.  
I don't know about magician since it was before my time but I suspect it
suffers from the same issue or that there's something else in there that
needs some other hardware more explicitly representing.

> I think maybe this is also the reason why the simple-card has common DAI
> format and CPU/CODEC private DAI formats at the same time.

I'd really want to see a real use case that actually was a simple card.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)