linux-kernel - [PATCHv2 1/2] tools lib traceevent: Replace tabs with spaces for all non-commands statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140102095304.GA1196@krava.brq.redhat.com>
Date:	Thu, 2 Jan 2014 10:53:04 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	David Ahern <dsahern@...il.com>
Subject: [PATCHv2 1/2] tools lib traceevent: Replace tabs with spaces for all
 non-commands statements

On Wed, Jan 01, 2014 at 01:59:44PM -0500, Steven Rostedt wrote:
> On Wed, 2014-01-01 at 17:50 +0100, Jiri Olsa wrote:
> > Replacing tabs with spaces for all non-commands statements
> > in 'Makefile'.
> > 
> 
> Instead of just stating what you did, can you also include a "why" you
> did it?

sry about that.. attached v2 with updated changelog

it was already discussed before in here:
http://marc.info/?t=136484403900003&r=1&w=2

thanks,
jirka


---
The tabbed indentation in non-commands statements could
be sometimes considered as follow up for the rule command
in the Makefile.

This error is hard to find, so as a precaution replacing
tabs with spaces for all non-commands statements.

Signed-off-by: Jiri Olsa <jolsa@...hat.com>
Cc: Corey Ashford <cjashfor@...ux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@...il.com>
Cc: Ingo Molnar <mingo@...e.hu>
Cc: Namhyung Kim <namhyung@...nel.org>
Cc: Paul Mackerras <paulus@...ba.org>
Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc: David Ahern <dsahern@...il.com>
Cc: Steven Rostedt <rostedt@...dmis.org>
---
 tools/lib/traceevent/Makefile | 54 +++++++++++++++++++++----------------------
 1 file changed, 27 insertions(+), 27 deletions(-)

diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
index ca4ab78..76fe0ae 100644
--- a/tools/lib/traceevent/Makefile
+++ b/tools/lib/traceevent/Makefile
@@ -86,8 +86,8 @@ ifeq ($(BUILD_SRC),)
 ifneq ($(OUTPUT),)
 
 define build_output
-	$(if $(VERBOSE:1=),@)+$(MAKE) -C $(OUTPUT) \
-	BUILD_SRC=$(CURDIR)/ -f $(CURDIR)/Makefile $1
+  $(if $(VERBOSE:1=),@)+$(MAKE) -C $(OUTPUT) \
+  BUILD_SRC=$(CURDIR)/ -f $(CURDIR)/Makefile $1
 endef
 
 all: sub-make
@@ -221,23 +221,23 @@ $(PLUGINS): %.so: %.o
 	$(QUIET_LINK)$(CC) $(CFLAGS) -shared -nostartfiles -o $@ $<
 
 define make_version.h
-	(echo '/* This file is automatically generated. Do not modify. */';		\
-	echo \#define VERSION_CODE $(shell						\
-	expr $(VERSION) \* 256 + $(PATCHLEVEL));					\
-	echo '#define EXTRAVERSION ' $(EXTRAVERSION);					\
-	echo '#define VERSION_STRING "'$(VERSION).$(PATCHLEVEL).$(EXTRAVERSION)'"';	\
-	echo '#define FILE_VERSION '$(FILE_VERSION);					\
-	) > $1
+  (echo '/* This file is automatically generated. Do not modify. */';		\
+   echo \#define VERSION_CODE $(shell						\
+   expr $(VERSION) \* 256 + $(PATCHLEVEL));					\
+   echo '#define EXTRAVERSION ' $(EXTRAVERSION);				\
+   echo '#define VERSION_STRING "'$(VERSION).$(PATCHLEVEL).$(EXTRAVERSION)'"';	\
+   echo '#define FILE_VERSION '$(FILE_VERSION);					\
+  ) > $1
 endef
 
 define update_version.h
-	($(call make_version.h, $@...p);		\
-	if [ -r $@ ] && cmp -s $@ $@...p; then		\
-		rm -f $@...p;				\
-	else						\
-		echo '  UPDATE                 $@';	\
-		mv -f $@...p $@;			\
-	fi);
+  ($(call make_version.h, $@...p);		\
+    if [ -r $@ ] && cmp -s $@ $@...p; then	\
+      rm -f $@...p;				\
+    else					\
+      echo '  UPDATE                 $@';	\
+      mv -f $@...p $@;				\
+    fi);
 endef
 
 ep_version.h: force
@@ -246,13 +246,13 @@ ep_version.h: force
 VERSION_FILES = ep_version.h
 
 define update_dir
-	(echo $1 > $@...p;	\
-	if [ -r $@ ] && cmp -s $@ $@...p; then		\
-		rm -f $@...p;				\
-	else						\
-		echo '  UPDATE                 $@';	\
-		mv -f $@...p $@;			\
-	fi);
+  (echo $1 > $@...p;				\
+   if [ -r $@ ] && cmp -s $@ $@...p; then	\
+     rm -f $@...p;				\
+   else						\
+     echo '  UPDATE                 $@';	\
+     mv -f $@...p $@;				\
+   fi);
 endef
 
 ## make deps
@@ -262,10 +262,10 @@ all_deps := $(all_objs:%.o=.%.d)
 
 # let .d file also depends on the source and header files
 define check_deps
-		@set -e; $(RM) $@; \
-		$(CC) -MM $(CFLAGS) $< > $@...$$; \
-		sed 's,\($*\)\.o[ :]*,\1.o $@ : ,g' < $@...$$ > $@; \
-		$(RM) $@...$$
+  @set -e; $(RM) $@; \
+  $(CC) -MM $(CFLAGS) $< > $@...$$; \
+  sed 's,\($*\)\.o[ :]*,\1.o $@ : ,g' < $@...$$ > $@; \
+  $(RM) $@...$$
 endef
 
 $(all_deps): .%.d: $(src)/%.c
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/