| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1388664474-1710039-12-git-send-email-arnd@arndb.de> Date: Thu, 2 Jan 2014 13:07:35 +0100 From: Arnd Bergmann <arnd@...db.de> To: linux-kernel@...r.kernel.org Cc: Arnd Bergmann <arnd@...db.de>, devel@...verdev.osuosl.org, Willy Tarreau <willy@...a-x.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Subject: [PATCH, RFC 11/30] staging: panel: fix interruptible_sleep_on race interruptible_sleep_on is racy and going away. This replaces the one caller in the panel driver with the appropriate wait_event_interruptible variant. Signed-off-by: Arnd Bergmann <arnd@...db.de> Cc: devel@...verdev.osuosl.org Cc: Willy Tarreau <willy@...a-x.org> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- drivers/staging/panel/panel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index cbc15c1..ec4b1fd 100644 --- a/drivers/staging/panel/panel.c +++ b/drivers/staging/panel/panel.c @@ -1590,8 +1590,8 @@ static ssize_t keypad_read(struct file *file, if (file->f_flags & O_NONBLOCK) return -EAGAIN; - interruptible_sleep_on(&keypad_read_wait); - if (signal_pending(current)) + if (wait_event_interruptible(keypad_read_wait, + keypad_buflen != 0)) return -EINTR; } -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists