linux-kernel - Re: [PATCH] sched_clock: Disable seqlock lockdep usage in sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 02 Jan 2014 14:21:41 -0800
From:	John Stultz <john.stultz@...aro.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Krzysztof Hałasa <khalasa@...p.pl>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>, Willy Tarreau <w@....eu>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] sched_clock: Disable seqlock lockdep usage in sched_clock

On 01/02/2014 02:15 PM, Linus Torvalds wrote:
> On Thu, Jan 2, 2014 at 1:54 PM, John Stultz <john.stultz@...aro.org> wrote:
>> Unforunately the seqlock lockdep enablmenet can't be used
>> in sched_clock, since the lockdep infrastructure eventually
>> calls into sched_clock, which causes a deadlock.
>>
>> Thus, this patch adds _no_lockdep() seqlock methods for the
>> writer side, and changes all generic sched_clock usage to use
>> the _no_lockdep methods.
> Ugh.
>
> On the x86 vclock_gettime() side, we only do this for the reader. Why
> did you make the generic version do it for the writer too, adding the
> necessity for those new operations? It's only the reader side that
> doesn't want it.

So the problem is that the update side calls the lockdep code which
calls sched_clock, which then deadlocks because the seqcount is odd
(held by the updater).

Thus we have to drop the lockdep usage in the updater as well.

On x86 vclock_gettime, we're in userspace, and that's why we can't call
the lockdep code. The update for that code however happens in kernel
space, so it doesn't have the same problem.


> Talking about the new operations, that "*_no_lockdep()" naming annoys
> me. It doesn't match the spinlock naming, which is to just use
> "raw_*()" instead. Wouldn't it be nice to make the naming be
> consistent too? Especially when it's paired with raw_local_irq_save()
> that shares that "raw_" model for non-checking stuff.

Sure, I can change the naming. New patch to follow in a bit.

thanks
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/