linux-kernel - Re: [PATCH 3/7] iommu/omap: Convert to devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140102010150.GA9933@earth.universe>
Date:	Thu, 2 Jan 2014 02:01:52 +0100
From:	Sebastian Reichel <sre@...g0.de>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:	Florian Vaussard <florian.vaussard@...l.ch>,
	Joerg Roedel <joro@...tes.org>,
	Tony Lindgren <tony@...mide.com>,
	Benoît Cousson <bcousson@...libre.com>,
	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Rob Landley <rob@...dley.net>,
	Grant Likely <grant.likely@...aro.org>,
	Hiroshi Doyu <hdoyu@...dia.com>,
	iommu@...ts.linux-foundation.org, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/7] iommu/omap: Convert to devicetree

Hi,

On Thu, Jan 02, 2014 at 01:13:42AM +0100, Laurent Pinchart wrote:
> > +		.of_match_table = omap_iommu_of_match,
> 
> If CONFIG_OF isn't defined (pretty unlikely I agree, but a possibility you 
> seem to be prepared for nonetheless given the above #if), this will fail to 
> compile.

FYI: This is avoided in other drivers by using
of_match_ptr(omap_iommu_of_match), which is replaced with NULL by
the preprocessor if CONFIG_OF is not defined.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)