lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 3 Jan 2014 11:27:47 +0000 From: David Vrabel <david.vrabel@...rix.com> To: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> CC: <linux-kernel@...r.kernel.org>, <xen-devel@...ts.xenproject.org>, <boris.ostrovsky@...cle.com>, <stefano.stabellini@...citrix.com>, <mukesh.rathor@...cle.com> Subject: Re: [PATCH v12 08/18] xen/pvh: Load GDT/GS in early PV bootup code for BSP. On 02/01/14 18:24, Konrad Rzeszutek Wilk wrote: >>> + loadsegment(es, 0); >>> + loadsegment(ds, 0); >>> + loadsegment(fs, 0); >>> +#else >>> + /* PVH: TODO Implement. */ >>> + BUG(); >>> +#endif >>> + return; <============== >>> + } >>> pv_cpu_ops.write_gdt_entry = xen_write_gdt_entry_boot; >>> pv_cpu_ops.load_gdt = xen_load_gdt_boot; >> >> If PVH uses native GDT why are these (and possibly other?) GDT ops needed? > > They aren't. There is a 'return' there. I marked it for you with > '<======'. I missed that, in which case. Reviewed-by: David Vrabel <david.vrabel@...rix.com> David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists