linux-kernel - Re: [PATCH resend] scripts: Coccinelle script for pm_runtime_* return checks with IS_ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140103134010.GA1676@sepie.suse.cz>
Date:	Fri, 3 Jan 2014 14:40:10 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	Nishanth Menon <nm@...com>, Gilles.Muller@...6.fr,
	nicolas.palix@...g.fr, linux-kernel@...r.kernel.org,
	cocci@...teme.lip6.fr, linux-pm@...r.kernel.org,
	Sekhar Nori <nsekhar@...com>,
	Russell King <rmk+kernel@....linux.org.uk>
Subject: Re: [PATCH resend] scripts: Coccinelle script for pm_runtime_*
 return checks with IS_ERR_VALUE

On Fri, Jan 03, 2014 at 02:29:35PM +0100, Julia Lawall wrote:
> 
> On Fri, 3 Jan 2014, Michal Marek wrote:
> 
> > On 2013-12-02 14:39, Nishanth Menon wrote:
> > > As indicated by Sekhar in [1], there seems to be a tendency to use
> > > IS_ERR_VALUE to check the error result for pm_runtime_* functions which
> > > make no sense considering commit c48cd65 (ARM: OMAP: use consistent
> > > error checking) - the error values can either be < 0 for error OR
> > > 0, 1 in cases where we have success.
> > >
> > > So, setup a coccinelle script to help identify the same.
> >
> > Julia, Gilles, do you have any objections to this semantic patch?
> 
> No objections.
> 
> Acked-by: Julia Lawall <julia.lawall@...6.fr>

Thanks, applied to kbuild.git#misc.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/