linux-kernel - Re: [PATCH 7/7] Fix uninitialised variable warning in mei-amt-version.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9629.1388766864@warthog.procyon.org.uk>
Date:	Fri, 03 Jan 2014 16:34:24 +0000
From:	David Howells <dhowells@...hat.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	dhowells@...hat.com, akpm@...ux-foundation.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Tomas Winkler <tomas.winkler@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] Fix uninitialised variable warning in mei-amt-version.c

Paul Bolle <pebolle@...cali.nl> wrote:

> But it turns out that call of mei_deinit() isn't needed at all. All of
> the members of mei_cl will be set later in mei_init() and none will be
> used before they are set. So we can simply drop this call of
> mei_deinit()."
> 
> Is that analysis (still) correct?

It looks true as the code stands.  Can you send me your patch?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/